Replace virt-install with libvirt go-binding#1
Open
alicefr wants to merge 8 commits into
Open
Conversation
The modular virtqemud daemon does not support TCP connections natively. Switch to monolithic libvirtd with socket activation via the built-in libvirtd-tcp.socket unit for direct TCP access from the host. Assisted-by: Claude <noreply@anthropic.com>
Use libvirt.org/go/libvirt and libvirt.org/go/libvirtxml to define and start VMs via direct TCP connection to libvirtd instead of shelling out to virt-install via podman exec. Domain configuration uses the functional option pattern with DomainOption closures composed at the call site. Assisted-by: Claude <noreply@anthropic.com>
The modular daemon sockets (virtnetworkd, virtstoraged) declare Conflicts=libvirtd.socket, preventing the monolithic libvirtd-tcp.socket from starting at boot. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The switch to libvirtd with TCP socket activation requires the cluster image to be rebuilt. Build it in CI and load it into the nested container to avoid pulling a stale image from the registry. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Re. alicefr/bink-deprecated#51 (comment) -- can you open a PR against bootc-operator before merging this? |
Collaborator
Author
|
@jlebon sure, I was even thinking of waiting and doing a first release before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace the call to virt-install using the libvirt go binding. The modular libvirt deamon don't support TCP that's why we move the monolithic daemon.
Fixes: #11