ephemeral run: Use correct None datasource for cloud-init - #320
Merged
Conversation
Signed-off-by: Mihai Petracovici <petracvv@users.noreply.github.com>
gursewak1997
force-pushed
the
cloud-init-datasource
branch
from
August 18, 2026 18:24
4014b66 to
b34d904
Compare
gursewak1997
approved these changes
Aug 18, 2026
There was a problem hiding this comment.
Pull request overview
Corrects cloud-init startup for ephemeral VMs by selecting the valid None datasource.
Changes:
- Replaces the mistaken instance ID with
ds=None. - Regression coverage is still needed.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing local images with cloud-init, I noticed that the application was crashing and not deploying basic config when running the image through bcvk. I traced this down to the qemu command using the incorrect data source.
iid-datasource-noneis the special instance id that cloud-init uses for theNonedatasource not the name of the datasource itself.This PR switches the kernel parameter to
Noneso we pass a valid datasource to cloud-init.