Repository navigation
core: rename has_vptr_fn to has_adl_vptr - #131
Merged
Merged
Conversation
The trait tells whether boost_openmethod_vptr, the customization point found by ADL, applies to a class. Its name read like a general "has a vptr function" test, which describes just as well the has_vptr that BOOST_OPENMETHOD_DETAIL_HAS_STATIC_FN generates next to it - a different extension point: a static member of virtual_traits, provided by the parameter's traits rather than by the class, for types that cannot carry an ADL overload of their own, such as std::any. The adl_ prefix follows adl_affinity, the library's other ADL customization point. Neither trait had a comment; both now say what they detect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jll63
added a commit
to jll63/openmethod
that referenced
this pull request
Oct 17, 2026
Brings develop up to the interop fix (boostorg#130) and the has_vptr_fn rename (boostorg#131), so this branch builds on its own with the new name, and the two PRs can land in either order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jll63
added a commit
to jll63/openmethod
that referenced
this pull request
Oct 17, 2026
The rename merged from fix/has-adl-vptr (boostorg#131) could not reach the one use this branch adds in init_bad_call: the merge is clean as text, and would not have compiled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
An automated preview of the documentation is available at https://131.openmethod.prtest3.cppalliance.org/libs/openmethod/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-17 15:37:40 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #131 +/- ##
========================================
Coverage 92.34% 92.34%
========================================
Files 27 27
Lines 2234 2234
Branches 677 677
========================================
Hits 2063 2063
Misses 112 112
Partials 59 59
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Written by Claude Code, on behalf of @jll63.)
Renames
detail::has_vptr_fntodetail::has_adl_vptr. No behaviour change.core.hpphas two traits next to each other that look like duplicates, and are not:has_adl_vptr<Class, Registry>(washas_vptr_fn)has_vptr<Traits, Arg>boost_openmethod_vptr(const Class&, Registry*), found by ADLTraits::vptr(arg)ofvirtual_traitsinplace_vptr_base, or theopenmethod_vptrtype-erasure conceptstd::any,boost::any,type_erasure::any,virtual_anyEach covers types the other cannot:
std::anylives innamespace std, where no ADL overload can be added. Andacquire_vptrtreats them in opposite ways, rejecting the hook and using the traits member, because a by-value pointer cannot be stored by an indirect registry.The old name read as "has a vptr function", which describes both. The
adl_prefix followsadl_affinity, the library's other ADL customization point. Neither trait had a comment; both now say what they detect.Ordering with #127: that PR adds a use of the old name in
init_bad_call. A textual merge of the two is clean, but the result would not compile, and GitHub would not notice.feature/dlltherefore merges this branch and renames its own use, so the two PRs can land in either order.Verified locally: CMake with clang-22, 198/198; b2 with gcc (
-Wextra -Werror), 128 passed, no warnings.🤖 Generated with Claude Code