-
Notifications
You must be signed in to change notification settings - Fork 254
ENH: add parameter finder for degrees or freedom for students_t distribution #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dschmitz89
wants to merge
10
commits into
boostorg:develop
Choose a base branch
from
dschmitz89:invert_student_t_to_df
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+242
−8
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
de6a562
ENH: add parameter finder for degrees or freedom
dschmitz89 7b015ec
Add early exit if approximation is precise to machine precision
dschmitz89 a1609a9
Loosen tolerance and add tests in the tails
dschmitz89 1cf9ea2
Modularize and simplify
dschmitz89 1132241
Use overflow error instead of inf
dschmitz89 123fdd1
Relax all test tolerances
dschmitz89 24c88ba
Should use a linter ..
dschmitz89 0c8365a
Relax test tolerance for float precision and remove ill conditioned t…
dschmitz89 1868814
Fix indentation
dschmitz89 b97dceb
Loosen tolerance for very high degrees of freedom
dschmitz89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a function for this here:
math/include/boost/math/distributions/students_t.hpp
Line 314 in 625d767
However, you have a better initial guess to the root finder which would be a very welcome addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this function but was not sure how to map the inversion problem we have here (finding degrees of freedom given a probability and a quantile) to this one arising from sample size calculation.
The signatures are:
find_degrees_of_freedom(RealType difference_from_mean, RealType alpha, RealType beta, RealType sd, RealType hint)invert_probability_with_respect_to_degrees_of_freedom(RealType x, RealType p)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK, slightly different problems, I would still overload the existing function though for consistency and call it:
find_degrees_of_freedom(RealType t_stat, RealType p)