-
Notifications
You must be signed in to change notification settings - Fork 248
Implementation of the log of the lower incomplete gamma function #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Implementation of the log of the lower incomplete gamma function #1349
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1349 +/- ##
========================================
Coverage 95.29% 95.29%
========================================
Files 814 814
Lines 67422 67422
========================================
Hits 64249 64249
Misses 3173 3173
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I think your added series is the same as the existing:
|
You're absolutely right. Based on the name of the function, I assumed it was a continued fraction implementation. This makes things a lot easier! |
|
I also changed the criteria for when the asymptotic series is used based on code paths in previous functions that used the asymptotic series. With my limited spot testing, this gives accurate results and is ready for testing. |
|
@jzmaddock I think this PR for the lower incomplete gamma function is nearly complete. I'm having some trouble testing long double types on ARM64 architectures where most of the tests are failing. The difference between my computed value and the expected is of order I'm now thinking the expected values are not quite right. I haven't been able to get Mathematica to output arbitrarily large precision so I've been using the mpmath library for Python. Do you happen to have the Mathematica code you used to calculate values for the upper incomplete gamma function? |
|
I'll bet the platform you are describing uses 10-byte floating-point representations for |
See #1346 and #1173.