Open
Conversation
Member
|
If this is supposed to be a rename, I'd rather the PR did just that, in one commit. At least, git should be able to tell this is a rename. Also, I probably won't remember to remove the outdated file, especially since I don't use Drone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most boost drone configurations call the main script
.drone/drone.sh. A few of the early deployments used.drone/boost.sh.To enable smart defaults it would be convenient to standardize on a name:
.drone/drone.sh.Multi-step process:
Merge this copy of
drone.shAfter 2 weeks, the defaults will change. In the event you haven't yet merged this PR, drone might stop working, but that can be easily fixed by merging this PR.
After 2 months (just to be careful) go ahead and delete your copy of
.drone/boost.sh. The relevant file will be.drone/drone.sh.