CMake improvements#10
Open
Flamefire wants to merge 3 commits intoboostorg:developfrom
Flamefire:cmake_improvements
Open
CMake improvements#10Flamefire wants to merge 3 commits intoboostorg:developfrom Flamefire:cmake_improvements
Flamefire wants to merge 3 commits intoboostorg:developfrom
Flamefire:cmake_improvements
Conversation
On interface targets _Boost_INCLUDEDIR/LIBRARYDIR were not `unset` Limit scope of them and remove _Boost_CMAKEDIR
Better encapsulation of common behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pdimov I created a PR for discussing proposed changes which is easier than the mailing list.
Basicall what I found:
_Boost_INCLUDEDIR/LIBRARYDIRare not unset for interface targetsunsetfor "temporary" variables.functionwhich adds a scope. To set "persistent" variables one needs to explicitely useset(... PARENT_SCOPE). I believe this makes it much more clear what is used where and passed backboost_<name>, but I wasn't entirely sure. Could you try to validate the behaviour especially for the (versioned) python stuff? I think there is justboost_pythonand aBoost_PYTHON_VERSIONvariable, isn't it?