feat: discover registered Solid Router pages - #10
Open
bompus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solid Router pages now appear as routes with exact component links when an imported Router registers JSX or literal configuration trees. Nested routes preserve Solid's base, path-array and parent-splat semantics; parent layouts do not become leaf pages. Static solid-js lazy imports resolve named defaults in the actual target module.
The resolver excludes orphan declarations, shadowed imports, mutated tables, dynamic paths and unsupported component expressions. React extraction no longer duplicates Solid's imported Route tags. Cross-file config tables, other router variants, inline/anonymous components and lazy re-exports remain unsupported.
Validation: the pinned 0.16.3 upstream README example reaches Home and Users; 23 focused tests cover precision, scoped framework introduction, edit/delete/reopened sync and fresh compiled workers. Build and TypeScript pass; 115 WASM framework/control tests pass; the full native suite passes 4,523 tests with 46 skips. Independent review findings were fixed and rechecked.
Step 8 of the approved framework plan. Stacked on #9; this PR contains only Solid Router changes.