Repository navigation
Conversation
trueberryless
approved these changes
Nov 9, 2026
trueberryless
left a comment
trueberryless
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me. I just left a small thought for further possible improvements for convenience, but no blocker
| | ------------------------------------------ | ----------------------------------------- | | ||
| | `pnpm test` | Runs every test | | ||
| | `pnpm test packages/ui/src/layout.test.ts` | Runs one test file | | ||
| | `pnpm lint` | Runs the linter | |
Collaborator
There was a problem hiding this comment.
Might be convenient to add a pnpm lint:check command, or to keep it consistent with the format naming convention, let lint check and add a lint:fix command.
And another command I have seen in some projects that is pretty convenient is a check:all command, which runs build, format, lint, unit tests. Wdyt? Could be a follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a contributing guide
Closes #50
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure