Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
4 of 12 tasks
cowboyd
force-pushed
the
dom-style
branch
2 times, most recently
from
October 17, 2026 04:50
e7746ec to
f9a19d4
Compare
cowboyd
force-pushed
the
dom
branch
2 times, most recently
from
October 17, 2026 05:00
0bb0996 to
ec40edd
Compare
cowboyd
force-pushed
the
dom-style
branch
6 times, most recently
from
October 19, 2026 14:43
4be9ca5 to
cad609c
Compare
commit: |
cowboyd
force-pushed
the
dom-style
branch
2 times, most recently
from
October 19, 2026 19:31
9fb0e99 to
02de507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a style system that hews as closely to CSS as possible. It is not, and cannot be, CSS compliant, but where CSS styles provide an answer, it uses it. It's fair to describe it as a subset of CSS.
This CSS based system is completely decoupled from TTY styling and so every property is explicitly mapped over. Included in this PR are styles for display, flex direction, spacing, borders, and CSS colors.
Currently there are only default styles and inline styles of an element, but we can later add style rules that match.
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure
I used AI to generate test cases, and occasionally suggest code snippets.