Repository navigation
Conversation
commit: |
dreyfus92
reviewed
Aug 23, 2026
dreyfus92
left a comment
Member
There was a problem hiding this comment.
left a few comments, thanks in advance Charles 💜
Contributor
|
Just noting I would like to review before we merge too 👍 I'll take a look tomorrow |
43081j
reviewed
Aug 24, 2026
| @@ -0,0 +1,167 @@ | |||
| // oxlint-disable no-explicit-any | |||
Contributor
There was a problem hiding this comment.
let's not, as it just means we're starting with a low bar.
use unknown where you genuinely don't know what the type is, and use never where you're trying to store/accept variable functions.
here's an example
Contributor
Author
|
closing out in favor of a DOM based substrate. See #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context can carry values through a tree, but Bombshell also needs behavior that can be extended within a subtree. Built-in elements, third-party elements, rendering policies, and framework integrations should all be able to participate in semantic operations without subclassing a central object or modifying the core implementation. A node-first API with inherited middleware makes that extension mechanism uniform across every subsystem added later.
Middleware remains correctly composed when a child already has local behavior and an ancestor is extended afterward. That property is essential for independently installed plugins and framework roots: extensions can be assembled in any practical order without duplicating inherited middleware or losing child-specific behavior.
This PR adds
createApi(), node-first invocation, and inheritedaround()middleware to the internal UI core. Tests verify middleware ordering, delegation, subtree inheritance, late ancestor installation, and composition with middleware already installed on descendants.