oxlint json parse failure fallback#37
Open
jbolda wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: acf2725 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
dreyfus92
approved these changes
Jun 13, 2026
dreyfus92
left a comment
Member
There was a problem hiding this comment.
lgtm, have you tested this fix already? 👀
Author
|
Aye, the "Result" snippet is running the preview package in the same repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some failure or no-op cases, oxlint seems to return output which is not json-parseable even with
--jsonpassed. I suspect these are mostly edge cases which we don't highly value handling. Went with a simple try/catch and log out the result instead.Example
Result
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure