deps: update pnpm and align node types version#515
deps: update pnpm and align node types version#51543081j merged 2 commits intobombshell-dev:mainfrom
Conversation
|
|
can you explain the downgrade of are you trying to match the types to the min node version? im not sure that makes the most sense since its a minimum (i.e. locally its unlikely we have that). plus it means we now have to remember not to update it whenever we update our dev dependencies. i think the latest is fine and we'd know if not, since the build would fail, and we want to be able to run clack in all modern nodes |
Yea the idea is that it's pinned so you know through types when you're using something that's too new. Ideally you'd be running the same Node version as your minimum support locally, then tests can do the higher ups. However, volta/nvm is only currently configured in the root so that may not happen so then you'd know because the types'd fail. I know it's a bit of a pain when you update deps but it's been worth it in my experience, however let me know if you'd like the change removed 🙏 |
commit: |
What does this PR do?
Updates pnpm to v10 as it works on Node 20, as well as downgrading the
@types/nodeto use v20 to alignType of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure