Skip to content

deps: update pnpm and align node types version#515

Merged
43081j merged 2 commits intobombshell-dev:mainfrom
ghostdevv:pnpm
Apr 23, 2026
Merged

deps: update pnpm and align node types version#515
43081j merged 2 commits intobombshell-dev:mainfrom
ghostdevv:pnpm

Conversation

@ghostdevv
Copy link
Copy Markdown
Contributor

What does this PR do?

Updates pnpm to v10 as it works on Node 20, as well as downgrading the @types/node to use v20 to align

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: 7a98d21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@43081j
Copy link
Copy Markdown
Collaborator

43081j commented Apr 22, 2026

can you explain the downgrade of @types/node?

are you trying to match the types to the min node version? im not sure that makes the most sense since its a minimum (i.e. locally its unlikely we have that). plus it means we now have to remember not to update it whenever we update our dev dependencies.

i think the latest is fine and we'd know if not, since the build would fail, and we want to be able to run clack in all modern nodes

@ghostdevv
Copy link
Copy Markdown
Contributor Author

are you trying to match the types to the min node version? im not sure that makes the most sense since its a minimum (i.e. locally its unlikely we have that). plus it means we now have to remember not to update it whenever we update our dev dependencies.

Yea the idea is that it's pinned so you know through types when you're using something that's too new. Ideally you'd be running the same Node version as your minimum support locally, then tests can do the higher ups. However, volta/nvm is only currently configured in the root so that may not happen so then you'd know because the types'd fail. I know it's a bit of a pain when you update deps but it's been worth it in my experience, however let me know if you'd like the change removed 🙏

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 23, 2026

commit: 7a98d21

@43081j 43081j merged commit cd7e5cd into bombshell-dev:main Apr 23, 2026
7 checks passed
@ghostdevv ghostdevv deleted the pnpm branch April 24, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants