feat(core): support number key jump in select prompt#513
Open
rodindev wants to merge 1 commit intobombshell-dev:mainfrom
Open
feat(core): support number key jump in select prompt#513rodindev wants to merge 1 commit intobombshell-dev:mainfrom
rodindev wants to merge 1 commit intobombshell-dev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d627413 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
We (maintainers) need to discuss the linked issue before we land something like this. Happy to leave this open until we decide though. if we accept every suggestion, its a quick way to end up bloating clack. so we do need to choose carefully which features should be accepted. ill report back to this PR once we've discussed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Press keys 1–9 in the select prompt to jump the cursor to that option. Out-of-range digits are ignored; if the target is disabled, the cursor skips forward to the next enabled option (same as the down-arrow). Enter still submits.
Closes #475
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure