Repository navigation
π‘οΈ Sentinel: [HIGH] Fix mXSS vulnerabilities in manual SVG sanitization - #227
Conversation
Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The manual SVG sanitizer
apps/web/src/lib/sanitize-svg.tsused an insufficient blocklist. It allowed<foreignObject>,<use>,<animate>,<set>,<image>, and<math>which could lead to mutation XSS (mXSS) and other attack vectors when rendering untrusted Mermaid or Math blocks.π― Impact: Attackers could inject arbitrary JavaScript by hiding it inside allowed elements, compromising user sessions and data.
π§ Fix: Expanded the
BLOCKEDSet to includeforeignobject,use,animate,set,image, andmathtags to proactively mitigate these vectors.β Verification: Ensure
npm testpasses inapps/web. Added test cases pass.PR created automatically by Jules for task 11682707313219212924 started by @bobdivx