Move more of Duration over to NonZeroSign #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
more-sign
branch
from
b794520 to
13cacbe
Compare
nekevss
approved these changes
Dec 23, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Worth noting, that the specification returns a Sign in the specification.
But generally speaking this is fine by me.
Contributor
Author
|
Oh, maybe I shouldn't then? I thought it was nonzero everywhere. I'll close then. |
Member
|
I think the problem tends to be that the sign operations are specified to return a 0, but there are steps that are non-zero in nature. Like step 18 of NudgeToCalendarUnit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#638