Skip to content

feat(engine): support f32 TryFromJs#5444

Open
AayushMainali-Github wants to merge 1 commit into
boa-dev:mainfrom
AayushMainali-Github:fix/5360-try-from-js-f32
Open

feat(engine): support f32 TryFromJs#5444
AayushMainali-Github wants to merge 1 commit into
boa-dev:mainfrom
AayushMainali-Github:fix/5360-try-from-js-f32

Conversation

@AayushMainali-Github

Copy link
Copy Markdown

Fixes #5360.

Summary

  • implement TryFromJs for f32
  • support both integer-backed and floating-point JavaScript numbers
  • return a TypeError for non-number values
  • cover integers, fractions, infinity, and invalid input

Testing

  • cargo test --workspace
  • cargo check --workspace --all-targets
  • cargo test -p boa_engine
  • cargo clippy -p boa_engine --all-targets -- -D warnings
  • cargo fmt --all -- --check

@AayushMainali-Github
AayushMainali-Github requested a review from a team as a code owner July 23, 2026 14:56
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Jul 23, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TryFromJs is not implemented for f32

1 participant