-
Notifications
You must be signed in to change notification settings - Fork 64
feat(engine): name an earlier attempt's parked work in retry dev prompts (#777) #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pbean
merged 2 commits into
fix/752-sweep-session-diagnostics
from
fix/777-retry-preserve-context
Sep 23, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the process exits after
_dev_phasesavesDEV_RUNNINGbut beforeadapter.runactually launches—such as during prompt construction, after a mutating pre-session hook, or on a transport startup error—this returns true even though no dev session was dispatched. If the pre-launch path left changes, recovery parks them withpreserve_from_attempt=True, and the next prompt incorrectly tells the agent that an earlier attempt produced those changes. Use a durable marker written at the actual launch boundary rather than treatingDEV_RUNNING, which is persisted before launch, as proof of dispatch.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing this; the window is real but the extra tracking isn't justified.
DEV_RUNNINGon a baseline tree. A failure beforeadapter.runleaves it clean, the rollback takes therollback-skipped-cleanreturn, andpreserve_from_attemptis stamped only on the dirty path. The other things that dirty the tree in that window are the fixable-repair tree and the intent-gap patch restore. Both hold work from an earlier dispatched attempt, so the attribution is still correct.A durable launch marker would mean a new persisted field and a state save on every session launch, just to cover a hook-writes-then-crash window. Before 5dc5ca1, the hard-stop/crash-mid-session resume left the notice out, and that is a common path.