Conversation
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gmoncor
force-pushed
the
docs/s01-11-pin-retirement-version-deprecated-engine
branch
from
September 23, 2026 10:03
957bb8f to
6e1a7dc
Compare
0.12.0 already shipped (tag v0.12.0, 2026-09-20) without removing [engine], so pinning the retirement notice to 0.12.0 would be false the moment this merges. Next real release is 0.13.0 per this repo's minor-bump convention for deprecation removals (0.11.0/0.12.0), so retargeted both the code comment and the runtime DeprecationWarning to it. Also moved the CHANGELOG entry from the already-published ## [0.12.0] section into ## [Unreleased] / ### Changed, where an unreleased change belongs per this file's own Keep a Changelog convention.
gmoncor
marked this pull request as ready for review
September 23, 2026 11:51
gmoncor
added a commit
to gmoncor/bmad-loop
that referenced
this pull request
Sep 23, 2026
CodeRabbit: same misplacement as bmad-code-org#810/bmad-code-org#811 — the entry landed inside the already-published ## [0.12.0] section instead of ## [Unreleased], and used narrative wording instead of this repo's imperative CHANGELOG convention. Moved and reworded; left src/bmad_loop/policy.py's stacklevel=3 as-is (not a clear bug: loads() is called both directly and via load(), which adds a frame — CodeRabbit's stacklevel=2 suggestion would be correct for the direct-call path but wrong for the load()-via-loads() path that tui/app.py actually uses in production, and stacklevel=3 matches the existing precedent at _fold_deprecated_engine in the same file).
gmoncor
added a commit
to gmoncor/bmad-loop
that referenced
this pull request
Sep 23, 2026
…OG placement Same bug already fixed in bmad-code-org#810/bmad-code-org#811: 0.12.0 (tag v0.12.0, released 2026-09-20) shipped without removing review.on_status_contradiction = "retry", so pinning the removal notice to 0.12.0 is false the moment this merges. Retargeted the comment, the runtime DeprecationWarning, core.toml's field description, and the test comment to 0.13.0 (this repo's minor-bump convention for deprecation removals). Also moved the CHANGELOG entry from the already-published ## [0.12.0] section into ## [Unreleased] / ### Changed, and reworded it as a terse imperative per this repo's own CHANGELOG guideline. Left the DeprecationWarning-visibility question (CodeRabbit: default Python filters suppress DeprecationWarning outside __main__, so this warning may not reach a user in normal CLI use) unresolved here — it's a pre-existing pattern shared with _fold_deprecated_engine, not specific to this PR, and fixing it well means a CLI-wide decision about warning categories/filters that's out of scope for a CHANGELOG/version fix; opening a separate issue for it.
This was referenced Sep 23, 2026
Author
|
Note for reviewers: this PR's DeprecationWarning (_fold_deprecated_engine) shares the same visibility gap tracked in #835 (discovered while addressing review feedback on #814) — Python suppresses DeprecationWarning by default outside main, so this notice likely doesn't reach a user in normal CLI use either. Not blocking this PR on it since it's cross-cutting and pre-existing, but flagging for awareness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Pin a concrete target version (and tracking issue) for retiring the
[engine]compatibility alias, in both the code comment and the runtimeDeprecationWarningmessage.Why: The alias says it is a "one-release" compatibility shim but names no version or issue, so nothing owns its removal — it can (and likely will) outlive its intended lifetime, matching a known anti-pattern already called out in this project's own review conventions.
How:
warnings.warnmessage.#149/#156/#157convention already used elsewhere in this same file.Testing:
uv run pytest -q tests/test_policy.py— 352 passed, 2 skipped. Confirms the deprecation-warning path still matches the updated message text.Changelog:
Changed: pinned a target version for the deprecated [engine] settings block.Related to #810
🤖 Generated with Claude Code