Skip to content

docs(policy): document safe range for dev_stall_nudges_cap - #809

Open
gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:docs/s01-10-document-dev-stall-nudges-safe-range
Open

gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:docs/s01-10-document-dev-stall-nudges-safe-range

Conversation

@gmoncor

@gmoncor gmoncor commented Sep 17, 2026 •

Copy link
Copy Markdown

What: Add one comment sentence to dev_stall_nudges_cap stating its safe range relative to session_timeout_min.

Why: The cap exists specifically to prevent bug #149 (a turn burned per cycle until session_timeout_min) from recurring, but nothing documents what value keeps that guarantee if dev_stall_nudges_cap or session_timeout_min change independently in the future. Related to #149 (closed), the original bug this cap guards against.

How:

  • Add a comment above dev_stall_nudges_cap noting it should stay comfortably below session_timeout_min / (dev_stall_grace_s/60) so the cap fires before the timeout ceiling would anyway.

Testing: Comment-only change; no behavior affected. Ran uv run pytest -q tests/test_policy.py (352 passed, 2 skipped) to confirm no regression.

Changelog: n/a (no user-visible change).

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d721a1e5-5131-4841-8c3e-85a5200283dd

📥 Commits

Reviewing files that changed from the base of the PR and between ddd2bf8 and 573c165.

📒 Files selected for processing (1)
  • src/bmad_loop/policy.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gmoncor
gmoncor force-pushed the docs/s01-10-document-dev-stall-nudges-safe-range branch from 244dbad to 573c165 Compare September 23, 2026 10:15
@gmoncor
gmoncor marked this pull request as ready for review September 23, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant