Skip to content

fix(tea-plugin): surface an operator-visible notice on fail-open gate verdicts - #807

Open
gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-08-surface-tea-fail-open-notice
Open

gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-08-surface-tea-fail-open-notice

Conversation

@gmoncor

@gmoncor gmoncor commented Sep 17, 2026

Copy link
Copy Markdown

What: When every configured artifact for a blocking gate returns a None verdict, emit a visible stderr notice naming the gate and that this is being treated as fail-open/pass, instead of silently continuing.

Why: The fail-open behavior itself is a deliberate, documented, and tested design choice and this PR does not change it; but today a fail-open pass leaves zero operator-visible trace.

How:

  • Add a stderr print at the point where artifact lookup yields a None verdict for every configured artifact of a gate, reusing the print-to-stderr convention already used by unity_setup.py/unity_teardown.py.
  • Do not change GATE_ARTIFACTS, the '|'-skip logic, or the fail-open return value.

Testing: Extend the existing test_missing_artifact_is_fail_open / test_garbled_artifact_is_fail_open tests to also assert on captured stderr, confirming the commit still proceeds.

Changelog: "Added: the TEA plugin now prints an operator-visible notice when a gate's artifacts can't be found or parsed and the gate fails open."

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e3d20f5a-f92e-418b-a886-4f9ade2033a8

📥 Commits

Reviewing files that changed from the base of the PR and between ddd2bf8 and c8c8c5c.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/bmad_loop/data/plugins/tea/tea_plugin.py
  • tests/test_plugin_tea.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gmoncor
gmoncor force-pushed the fix/s01-08-surface-tea-fail-open-notice branch from e8131f1 to c8c8c5c Compare September 23, 2026 10:11
@gmoncor
gmoncor marked this pull request as ready for review September 23, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant