Normalize config paths across platforms#289
Closed
ramcguire wants to merge 1 commit into
Closed
Conversation
Expand `~` and `~/...` in config path overrides on Windows while keeping `~\...` style paths Windows only. Normalize LSP workspace relative paths to forward slashes so config matching is consistent across platforms.
Owner
|
Hey! Thanks for the poke on this. I don't have a Windows machine handy, so support has been best-effort. Anyway, I've taken the report and spun out a PR I think more aligns with the codebase: #293 I'll close this in favor of that. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
~and~/...in config path overrides on Windows while keeping~\...style paths Windows only. Normalize workspace relative paths to forward slashes so config matching is consistent across platforms.This is useful when using shared dotfiles across platforms, for example using the same global config in both WSL and Windows. Also makes workspace relative paths consistent. Note that this may have a side effect if someone were using Windows specific override globs, e.g.