Open
Conversation
chands10
force-pushed
the
nostack
branch
2 times, most recently
from
a53fb1d to
4df4d79
Compare
roborivers
suggested changes
Apr 14, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
chands10
commented
Apr 14, 2026
| export cdb2_open=${TESTSBUILDDIR}/cdb2_open | ||
|
|
||
| echo "Running with stack enabled" | ||
| out=$($cdb2_open -c $CDB2_CONFIG -d $db 2>&1) |
Contributor
Author
There was a problem hiding this comment.
I don't even think this was running with stack enabled
chands10
commented
Apr 14, 2026
| target_link_libraries(stepper util mem util dlmalloc) | ||
| target_link_libraries(test_threadpool util mem util dlmalloc) | ||
| target_link_libraries(test_consistent_hash util mem util dlmalloc crc32c) | ||
| target_link_libraries(test_consistent_hash_bench util mem util dlmalloc crc32c) |
Contributor
Author
There was a problem hiding this comment.
Circular dependencies
mponomar
approved these changes
Apr 14, 2026
roborivers
approved these changes
Apr 14, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
noresetgen
consumer_non_atomic_default_consumer_generated **quarantined**
api_tst
reco-ddlk-sql [timeout] **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we remove this then don't need libunwind for cdb2api
Looks like java api sends stack by default, left that in