Reports JAVA_HOME (JDK/JRE path) as the task name#5861
Reports JAVA_HOME (JDK/JRE path) as the task name#5861hgeraldino wants to merge 1 commit intobloomberg:mainfrom
Conversation
…he caller class. Caller class is still included in the stack, so information is not lost Signed-off-by: Hector Geraldino <hgeraldino@bloomberg.net>
|
|
||
| @Deprecated | ||
| public static String getCallerClass() { | ||
| logger.warn("getCallerClass() is deprecated and will be removed in a future version"); |
There was a problem hiding this comment.
Do we need to print it every time this function is called?
There was a problem hiding this comment.
Just wanted to note that this function is no longer called anywhere in this codebase.
I don't expect clients to be calling this function explicitly (it is not part of the JDBC API), this could've been a private or package-private method. If there's any client who is calling this function for any reason (can't think of one), then it is fine for them to see this warning IMO.
I don't think it's worth adding extra complexity to avoid additional logging for something like this, but if you strongly feel like we should, I'm happy to refactor it.
|
|
||
|
|
||
| public static String getJavaHome() { | ||
| return System.getProperty("java.home"); |
There was a problem hiding this comment.
I haven't figured out how to run tests, but also the value for this property will be different on each environment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_truncate [db unavailable at finish]
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**
What is the type of the change (bug fix, feature, documentation and etc.) ?
feature
What are the current behavior and expected behavior, if this is a bugfix ?
Other interpreted languages (like Python) report their runtimes. This PR brings JVM applications on par with applications written in other languages (both interpreted languages and compiled ones)
What are the steps required to reproduce the bug, if this is a bugfix ?
What is the current behavior and new behavior, if this is a feature change or enhancement ?
Currently, the
comdb2_clientstatstable reports the calling class as the task name.With this change, the task name will report the JDK/JRE used to launch the task, while the calling class will still be the first entry on the stack.
Helps determine which task/runtime is being used by the calling process.