Repository navigation
Fix stats dump interval validation - #109
Merged
pniedzielski merged 2 commits intoOct 19, 2026
Merged
Conversation
pniedzielski
previously approved these changes
Oct 16, 2026
pniedzielski
approved these changes
Oct 16, 2026
Signed-off-by: Myles Lee <myungeun2dc@gmail.com>
Signed-off-by: Myles Lee <myungeun2dc@gmail.com>
pniedzielski
force-pushed
the
fix/stats-dump-interval-validation
branch
from
October 16, 2026 21:05
69036c9 to
b6e7632
Compare
pniedzielski
approved these changes
Oct 16, 2026
pniedzielski
left a comment
Contributor
There was a problem hiding this comment.
(I've resolved a merge conflict brought about by merging #111; it was just documentation.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate
stats_dump_intervalas a multiple of 30 seconds below 60 minutes before passing it to the native client. This raisesValueErrorfor values such as 3600 and 31 seconds instead of triggering a C++ assertion that terminates the Python process.Update the documented range to
[0s, 60min)and add regression coverage for rejected values and the largest valid value, 3570 seconds.Closes: #108
Testing
tests/unit/test_session.py: 80 passed on Python 3.12/macOS arm64 using the source Python package with the published 1.2.2 native extension.SessionandSession.with_optionsreject invalid values before native construction;Noneand valid values (including 0 and 3570 seconds) are forwarded unchanged to the native constructor.