Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an application uses DB storage only for selected attachments, the engine still downloads and uploads through
ActiveStorage::Blob.service. With Disk or S3 as the application default, DB attachment requests therefore reach the wrong service.Add an optional engine configuration:
The controller resolves the configured string or symbol through the Active Storage service registry for both downloads and direct uploads. The default is
nil, preserving the existing application-default behavior. Unknown names raise the registry error. The application default, signed URLs, and database schema are unchanged.Includes mixed-storage documentation and request coverage for string/symbol names, downloads, direct uploads, fallback, and unknown names.
Validation
Style/RedundantParenthesesoffense atspec/service/active_storage/service/db_service_spec.rb:195, unchanged from upstream main.For the full local suite, installed libvips and added
ruby-vips ~> 2.3through an ignored supplemental validation Gemfile; the currently resolvedimage_processing2.2.0 does not bring that dependency into the standard bundle. No dependency changes are included in this PR. The existing upstream workflows cover the broader Rails/database matrix.