Skip to content

Stabilize nested relationship request assertions - #1318

Merged
jwils merged 1 commit into
mainfrom
joshuaw/stabilize-nested-request-count
Jul 31, 2026
Merged

Stabilize nested relationship request assertions#1318
jwils merged 1 commit into
mainfrom
joshuaw/stabilize-nested-request-count

Conversation

@jwils

@jwils jwils commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Why

Nested relationship acceptance tests assumed that each logical search would use a separate _msearch transport request. Fiber scheduling can batch the same six searches into five requests, causing unrelated changes such as #1316 to fail despite correct results and routing.

What

  • Stop asserting the transport request count in the bi-directional nested relationship test
  • Continue asserting six logical datastore searches and their exact shard routing

Risk Assessment

Low — this is a test-only change that preserves the result, query-count, and routing coverage.

References

@jwils
jwils marked this pull request as ready for review July 31, 2026 01:50
@jwils
jwils merged commit cc58401 into main Jul 31, 2026
37 of 39 checks passed
@jwils
jwils deleted the joshuaw/stabilize-nested-request-count branch July 31, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants