Fix stray double quote in SearchFailedError message#1262
Open
jwils wants to merge 1 commit into
Open
Conversation
The heredoc that formats datastore search failures had a dangling " after the inspected error hash, which leaked a literal double quote into the operator-facing `Errors::SearchFailedError` message. Removed it and extended the existing spec to guard against the regression.
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The heredoc that formats datastore search failures in
DatastoreSearchRouter#raise_search_failed_if_any_failureshad a dangling"immediately after the inspected error hash:#{response.fetch("error").inspect}"This leaked a literal double quote into the operator-facing
Errors::SearchFailedErrormessage (e.g.{"bad stuff" => "happened"}").Changes
"from the heredoc inelasticgraph-graphql/lib/elastic_graph/graphql/datastore_search_router.rb.Errors::SearchFailedError" spec to assert the message does not contain the dangling quote, guarding against regression.Testing