-
Notifications
You must be signed in to change notification settings - Fork 1
Dark mode: fix highlight text + add theme preference setting #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
94f80a4
Fix comment highlight text color in dark mode
HamptonMakes b61a55e
Add theme preference setting (System/Light/Dark)
HamptonMakes 080de51
Redesign theme switcher as compact segmented control with icons
HamptonMakes 56bec22
Put theme switcher in a card with bigger buttons
HamptonMakes d0b3069
Merge auth metadata instead of replacing it
HamptonMakes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
engine/app/javascript/controllers/coplan/theme_controller.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { Controller } from "@hotwired/stimulus" | ||
|
|
||
| export default class extends Controller { | ||
| static values = { url: String } | ||
|
|
||
| select(event) { | ||
| const theme = event.target.value | ||
| if (theme === "system") { | ||
| document.documentElement.removeAttribute("data-theme") | ||
| } else { | ||
| document.documentElement.setAttribute("data-theme", theme) | ||
| } | ||
|
|
||
| const meta = document.querySelector('meta[name="color-scheme"]') | ||
| if (meta) { | ||
| meta.content = theme === "system" ? "light dark" : theme | ||
| } | ||
|
|
||
| const csrfToken = document.querySelector('meta[name="csrf-token"]')?.content | ||
| fetch(this.urlValue, { | ||
| method: "PATCH", | ||
| headers: { | ||
| "Content-Type": "application/x-www-form-urlencoded", | ||
| "X-CSRF-Token": csrfToken | ||
| }, | ||
| body: `theme=${theme}` | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saving
theme_preferenceinsidemetadatawill be clobbered in common host setups becauseauthenticate_coplan_user!reassignsattrs[:metadata]on every request (and the integration guide’s example returnsmetadata: {}). In that flow, a user can select Dark, but the next request overwritesmetadataand resets to System, so the new setting is not actually persistent. This preference needs to live in a field that is not rewritten by auth sync (or merge preserved keys before assignment).Useful? React with 👍 / 👎.