refactor: use structured log attributes instead of fmt.Sprintf#196
Merged
jrobotham-square merged 1 commit intomainfrom Mar 17, 2026
Merged
refactor: use structured log attributes instead of fmt.Sprintf#196jrobotham-square merged 1 commit intomainfrom
jrobotham-square merged 1 commit intomainfrom
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ce5cd-b9eb-77c8-a7b5-c2b819e60102 Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019ce5cd-b9eb-77c8-a7b5-c2b819e60102 Co-authored-by: Amp <amp@ampcode.com>
jrobotham-square
force-pushed
the
jrobotham/structured-logging
branch
from
a893b69 to
85c222b
Compare
stuartwdouglas
approved these changes
Mar 17, 2026
alecthomas
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace interpolated log values with structured slog attributes.
internal/httputil/logging.go: splitrequestfield into separatemethodanduriattributesinternal/strategy/git/git.go: remove duration from error string (already logged as structured field on success)