Conversation
Signed-off-by: Eran Rom <erom@neo.ai>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A saved community can become impossible to remove when its relay goes down or returns HTTP 404, because Leave community requires relay communication before local cleanup.
After Leave community fails because the relay is unavailable, offer a confirmed Remove from this device fallback beneath the error. It removes the saved connection without contacting the relay, keeps the user's identity, and switches to another community or returns to community discovery. The confirmation explains that server membership is unchanged and the community itself is not deleted.
Recognize network failures, disconnected WebSockets, leave-request timeouts, and HTTP 404/410/5xx responses. Relay permission errors and owner restrictions do not expose this fallback.
Reuse the existing local cleanup and navigation flow. Leave community continues to require relay acceptance.
Related issue
Fixes #7754.
Related: #7049, #7097 and #3621. This covers local removal when the relay is unavailable, including the HTTP 404 case; #7097 addresses revoked membership with a reachable relay.
Testing
git diff --checkalso passed.Full
just cipassed, using the repository-required nextest 0.9.136 from a temporary tools directory. This includes repository lint/policy checks, Rust/native/desktop/mobile tests, and desktop/web builds.Screenshots
Captured with the mocked Tauri bridge; no live relay or installed app was used.
Before: the failed leave has no local-removal action.
After: the availability error exposes the local-removal fallback.
Confirmation explains the effect on the device and server membership.