Conversation
ACP sandboxes that strip *_KEY env (for example dsh) drop BUZZ_PRIVATE_KEY from the child shell, so buzz CLI auth fails silently. Spawn the same MCP sidecar builtins already use so session/new injects credentials outside that sandbox. Presets stay sidecar-less. Signed-off-by: 有福 <shenbowen202211@163.com> Co-authored-by: Cursor <cursoragent@cursor.com>
🔐 Codex Security Review
|
Keep both the custom-harness MCP sidecar spawn-snapshot regression and main's session-policy retention test after the tests_ext.rs conflict. Signed-off-by: 有福 <shenbowen202211@163.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dsh) now spawn with thebuzz-dev-mcpsidecar, the same path builtins already use for Buzz CLI auth.*_KEYenv dropBUZZ_PRIVATE_KEYfrom the child shell;session/newinjects credentials into the sidecar instead sobuzz messages sendcan publish.Test plan
mcp_command, spawn snapshot mountsbuzz-dev-mcp; presets remain empty.save_custom_harnessreturnsmcp_command: "buzz-dev-mcp".buzz messages sendno longer dies on missingBUZZ_PRIVATE_KEYin default bash).buzz-dev-mcpsidecar.Made with Cursor