Skip to content

fix(desktop): mount buzz-dev-mcp on custom harnesses - #7752

Open
Bowen2024 wants to merge 2 commits into
block:mainfrom
Bowen2024:feat/custom-harness-mcp-sidecar
Open

Bowen2024 wants to merge 2 commits into
block:mainfrom
Bowen2024:feat/custom-harness-mcp-sidecar

Conversation

@Bowen2024

Copy link
Copy Markdown

Summary

  • Custom ACP harnesses (for example DeepSeek dsh) now spawn with the buzz-dev-mcp sidecar, the same path builtins already use for Buzz CLI auth.
  • ACP sandboxes that strip *_KEY env drop BUZZ_PRIVATE_KEY from the child shell; session/new injects credentials into the sidecar instead so buzz messages send can publish.
  • Presets stay sidecar-less. This does not inject the nsec into the harness definition env or the default agent bash.

Test plan

  • Desktop unit tests: custom harness command match, catalog mcp_command, spawn snapshot mounts buzz-dev-mcp; presets remain empty.
  • E2E mock save_custom_harness returns mcp_command: "buzz-dev-mcp".
  • Live: Buzz Dev + DeepSeek custom harness; agent published to the channel via the MCP shell (buzz messages send no longer dies on missing BUZZ_PRIVATE_KEY in default bash).
  • Restart an existing custom-harness agent after this build and confirm it does not fall back to Codex when the harness JSON is present.
  • Confirm Cursor / other presets still have no buzz-dev-mcp sidecar.

Made with Cursor

ACP sandboxes that strip *_KEY env (for example dsh) drop BUZZ_PRIVATE_KEY from the child shell, so buzz CLI auth fails silently. Spawn the same MCP sidecar builtins already use so session/new injects credentials outside that sandbox. Presets stay sidecar-less.

Signed-off-by: 有福 <shenbowen202211@163.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Bowen2024
Bowen2024 requested a review from a team as a code owner September 19, 2026 08:04
@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 4e65148e76bd4f8dff757da4014a37fbc95fcc12...f017791c91ebdcc7e4e5dc2c7923ded8c9ebd39e.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review f017791c91ebdcc7e4e5dc2c7923ded8c9ebd39e to authorize a new review.
Any previous review applies only to its recorded range.

Keep both the custom-harness MCP sidecar spawn-snapshot regression and
main's session-policy retention test after the tests_ext.rs conflict.

Signed-off-by: 有福 <shenbowen202211@163.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant