Skip to content

buzz-acp: record explicit terminal outcomes - #7747

Open
cmcgrabby-hue wants to merge 2 commits into
block:mainfrom
cmcgrabby-hue:ops-13-g2-acp-error-terminal-outcomes
Open

cmcgrabby-hue wants to merge 2 commits into
block:mainfrom
cmcgrabby-hue:ops-13-g2-acp-error-terminal-outcomes

Conversation

@cmcgrabby-hue

Copy link
Copy Markdown

Summary

  • classify ACP/provider errors without exposing raw provider messages
  • correlate queue admission, worker, provider turn, retry attempt, and terminal outcome
  • record explicit signed, requeued, dead-lettered, or abandoned terminal classes
  • preserve intact application-error workers while retaining scoped respawn behavior for fatal outcomes

Verification

  • named two-worker / three-queue regression: 1 passed, 0 failed
  • buzz-acp package: 951 effective checks passed, 0 failed, 1 ignored
  • full just ci: exit 0
  • git diff --check: clean

Safety boundaries

  • correlation IDs contain only channel/event IDs hashed with SHA-256
  • raw provider messages, prompt bodies, tokens, and secrets are excluded from terminal observer frames and application-error logs
  • no queue replay, live install, agent restart, or business-system mutation

Linear: OPS-13

Signed-off-by: Kade Lai <267390149+cmcgrabby-hue@users.noreply.github.com>
@cmcgrabby-hue
cmcgrabby-hue requested a review from a team as a code owner September 18, 2026 19:46
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 4e1770aa3ee7552e2bb50e897e113c22e30488de...9b8b1644d01ce8ef8940afaf02f4d4411eb38ad1.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 9b8b1644d01ce8ef8940afaf02f4d4411eb38ad1 to authorize a new review.
Any previous review applies only to its recorded range.

Signed-off-by: Kade Lai <267390149+cmcgrabby-hue@users.noreply.github.com>
@cmcgrabby-hue
cmcgrabby-hue force-pushed the ops-13-g2-acp-error-terminal-outcomes branch from 84f4d83 to 9b8b164 Compare September 18, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant