Gate enterprise relay login on discovery - #7715
Open
bradseiler wants to merge 8 commits into
Open
bradseiler wants to merge 8 commits into
bradseiler wants to merge 8 commits into
Conversation
added 5 commits
September 17, 2026 15:42
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
🔐 Codex Security Review
|
added 3 commits
September 18, 2026 16:55
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
Signed-off-by: coder 1 <a93f3b1decd199cec83848f116ff60c20776cdd03861b9bba2610acae7c9eeeb@buzz.block.builderlab.xyz>
bradseiler
marked this pull request as ready for review
September 18, 2026 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the desktop client gate for enterprise relay login. When a relay advertises a privacy-safe
federated_identityrequirement through NIP-11, the client requires the trusted browserLogin flow before community admission.The client treats relay discovery as a signal only. It still requires the selected relay to match trusted compile-time enterprise provider config, and it never reads login, assertion, provider, or credential URLs from NIP-11.
This PR also hardens the login lifecycle. It fences stale attempts, preserves cancel-before-native-registration tombstones, bounds tombstone retention, and commits session state while holding the browserLogin lock.
The Buzz client now consumes the revised BuilderLab identity response shape. It reads
usernameandnamefrom the exchange and/auth/meresponses. It treats the profile as authoritative only when both independently trimmed values are present. When the authoritative corporate profile write fails, the flow stays non-editable and offers a retry that persists the same values.Scope excludes session persistence, NIP-FI assertion issuance, NIP-42 relay auth, mobile support, and release-repo config.
Base:
origin/mainat4e1770aa3ee7552e2bb50e897e113c22e30488de.Head:
6ecda5ca0719a90e6c19bd5ee631a94e33acd67d.Related issue
None found.
Testing
At
6ecda5ca0719a90e6c19bd5ee631a94e33acd67d:cargo test --manifest-path desktop/src-tauri/Cargo.toml builderlab --no-fail-fast— passed, 15 relevant tests and 3231 filtered.pnpm --dir desktop typecheck— passed.biome checkon touched desktop files — passed.authoritative corporate profile save failure stays non-editable and retries exact values— passed.6ecda5ca0719a90e6c19bd5ee631a94e33acd67d— passed:push-head-scope,branch-skew,desktop-check,file-size-check,desktop-typecheck,desktop-test, anddesktop-tauri-checks..scratch/enterprise-login-gate-live-6ecda5ca: built the release at the exact SHA, started the relay, confirmed readiness, created a channel, and sent/read a message. Docker CLI was unavailable because it required org sign-in, so the run used already-listening local Postgres and Redis ports with an isolated scratch database.Generated with Codex