fix(desktop): make starter profiles optional and removable - #7466
JackHunzicker wants to merge 1 commit into
Conversation
Signed-off-by: Jack <JLHunzicker@gmail.com>
🔐 Codex Security Review
|
|
Support. Optional, removable starter profiles reduce unwanted local agents without changing relay identity cleanup. This complements #7465 by covering built-in profiles separately. |
|
+1 from a user hitting #6914 on v0.5.24. This PR would fix it. One case worth covering in review or tests: customized built-in personas get cloned into a second community's Welcome Team. I had edited With this PR, "Missing Welcome Teams are not automatically recreated" and "onboarding respects inactive starters" should stop the respawn. It isn't clear to me whether a customized, active built-in would still be copied into a new community on first onboarding. That may deserve a guard, such as seeding from the stock definition or skipping customized built-ins. |
Summary
Starter personas and the built-in Welcome Team are currently forced into every user's inventory and re-created after removal. This PR keeps the templates available by explicit choice instead.
Independent of #7419. Based on
3c7f288c60d67df78577b237e27c3dfc8831aaa1. No change to agent runtime/harness configuration, no second profile store, and the stock template definitions themselves are not removed.Related issue
Fixes #5553 (allow hiding or disabling built-in personas and the Welcome Team). Adjacent, not duplicates: #5979 (channel-membership repair after a completed kickoff; this PR touches
welcomeKickoff.tson one line and should compose with it), #5319 / #6211 (per-device duplicate agents).Testing
cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --locked). Native regressions cover local-only built-in deletion, custom-team tombstone retention through the same production seam, opt-out survival through the real startup migration/fold, and no automatic Welcome Team re-creation.pnpm test, both globs).pnpm build:e2e(TypeScript check + mock-bridge build) passed.tests/e2e/removable-defaults.spec.ts): 2 passed: starter templates are opt-in and can be removed again; deleting the built-in Welcome Team leaves a custom look-alike team intact.git diff --check, andjust file-size-checkpass.Verified on Windows (x86_64-pc-windows-msvc). The full
just cion this host surfaced a set of pre-existing Windows-only Clippy/test-fixture issues onmainthat are unrelated to this change; I have those fixed locally and will open them as a separate PR so this one stays scoped.Screenshots (mock bridge):