test(deploy): validate production Compose renders - #4759
Open
SmithLabsLLC wants to merge 1 commit into
Open
Conversation
Signed-off-by: Smith Labs LLC <232409717+SmithLabsLLC@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configurations
Why
The production Compose bundle previously had only a manual validation
checklist. Override or interpolation errors could therefore merge without any
automated render coverage.
The test copies only checked-in Compose files and
.env.exampleplaceholdersto a disposable directory. It runs
docker compose config --quietand does notstart containers or create volumes or networks.
Testing
shellcheck deploy/compose/run.sh deploy/compose/test.shbash -n deploy/compose/run.sh deploy/compose/test.shdeploy/compose/test.sh.github/workflows/compose.ymlgit diff --checkAll four Compose combinations rendered successfully.
Review
One Fable 5 xhigh review initially returned
NEEDS CHANGES. All acceptedfindings were incorporated: the draft covers the combined TLS-development
merge, triggers on
prometheus.yml, and cancels superseded pull-request runs.The executable mode is preserved. No second independent review was run.
Scope
This adds a CI signal. It does not change branch-protection settings, start a
deployment, read a real
.env, or change runtime behavior.