fix(desktop): clear stale instance agent args on harness switch - #4670
Open
joshualwrnc wants to merge 1 commit into
Open
fix(desktop): clear stale instance agent args on harness switch#4670joshualwrnc wants to merge 1 commit into
joshualwrnc wants to merge 1 commit into
Conversation
Instance agent_args are harness-specific and win over the harness definition's default args at spawn. apply_agent_command_update updated the runtime pin without touching record.agent_args, so switching an agent's harness (e.g. Grok Build to Oh My Pi) left the old harness's flags in place and every spawn passed them verbatim to the new binary: omp launched as `omp agent --always-approve stdio` and crash-looped on `unknown flag: --always-approve`. Clear record.agent_args when the edit changes the effective command. Same-command re-saves keep customized args, and replacement args sent in the same update are applied after the clear, so the edit dialog's harness-switch flow (which sends the new harness's defaults) is unaffected. Co-authored-by: joshualwrnc <75241961+joshualwrnc@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: joshualwrnc <75241961+joshualwrnc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Instance
agent_argsare harness-specific and win over the harness definition's default args at spawn.apply_agent_command_updateupdated the runtime pin without touchingrecord.agent_args, so switching an agent's harness (e.g. Grok Build → Oh My Pi) left the old harness's flags in place and every spawn passed them verbatim to the new binary:omplaunched asomp agent --always-approve stdioand crash-looped onunknown flag: --always-approve.Fix
Clear
record.agent_argswhen the edit changes the effective command. Same-command re-saves keep customized args, and replacement args sent in the same update are applied after the clear, so the edit dialog's harness-switch flow (which sends the new harness's defaults) is unaffected.Testing
managed_agents/discovery/tests.rsfor the harness-switch clear, same-command preserve, and replace-after-clear paths