fix(relay): allow deleting archived channels - #4669
Open
sweetpeahospitality-hue wants to merge 1 commit into
Open
fix(relay): allow deleting archived channels#4669sweetpeahospitality-hue wants to merge 1 commit into
sweetpeahospitality-hue wants to merge 1 commit into
Conversation
Co-authored-by: Christopher Stimson <sweetpeahospitality@gmail.com> Signed-off-by: Christopher Stimson <sweetpeahospitality@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kind:9008delete event on an archived channelRoot cause
The relay rejected every event on an archived channel except an explicit unarchive. That rejected
kind:9008before owner authorization and the existing soft-delete handler could run.Testing
cargo test -p buzz-relay archived_channel_(3 passed)cargo clippy -p buzz-relay --all-targets -- -D warningscargo test -p buzz-test-client --test e2e_relay --no-runcargo fmt --all -- --checkcargo test -p buzz-relay(832 passed; 9 unrelated DB-backed failures fromSqlx(PoolTimedOut)and the resulting 500-vs-404 assertions; 37 ignored)Buzz source channel:
cff6052e-5fd2-4e4b-a435-b4b1591c20a9