Skip to content

fix(security): redact secrets from remote-agent deploy payload - #4666

Open
joshpalerlin wants to merge 2 commits into
block:mainfrom
joshpalerlin:luna/follow-scope
Open

fix(security): redact secrets from remote-agent deploy payload#4666
joshpalerlin wants to merge 2 commits into
block:mainfrom
joshpalerlin:luna/follow-scope

Conversation

@joshpalerlin

Copy link
Copy Markdown

Summary

  • Fixes secret exposure in the remote-agent deploy payload — environment variables (including API keys, tokens, and credentials) were being passed in plaintext when launching agents
  • Introduces typed DeployPayloadContext to structurally enforce redaction of all three environment maps (system, user, provider) before they leave the host
  • Resolves clippy argument-count lint without suppression
  • Updates docs/remote-agents.md Known Defect 3 to mark the launch-payload and three-map redaction as resolved

Test plan

  • All 2,114 Desktop library tests pass (verified by Sol in Docker with Rust 1.95)
  • cargo fmt --check passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • Two new backend redaction regression tests pass
  • Four-file scope verified: agents_deploy.rs, agents_tests.rs, managed_agents/backend.rs, docs/remote-agents.md

Review

Independently reviewed by Sol across 3 rounds — HARD PASS verdict on final round.

🤖 Generated with Claude Code

Signed-off-by: Jarvis <support@joshpalerlin.com>
Co-authored-by: Jarvis <support@joshpalerlin.com>
Co-authored-by: Jarvis <support@joshpalerlin.com>
Signed-off-by: Jarvis <support@joshpalerlin.com>
@joshpalerlin
joshpalerlin requested a review from a team as a code owner August 4, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants