feat(desktop): render activity bar on non-managing owner devices - #4661
Open
TolgaCinisli wants to merge 1 commit into
Open
feat(desktop): render activity bar on non-managing owner devices#4661TolgaCinisli wants to merge 1 commit into
TolgaCinisli wants to merge 1 commit into
Conversation
The composer activity bar required the working agent to exist in this install's managed-agent registry, so a second desktop signed in with the same owner identity showed nothing during turns. The observer stream is owner-scoped, not install-scoped — fall back to profile-lookup display entries when the registry has no match, keeping managed entries preferred. Signed-off-by: Tolga Cinisli <tolgacinisli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composer activity bar only rendered when the working agent was present in
this install's managed-agent registry. Sign in on a second desktop with the
same owner identity and the bar stayed dark for the whole turn, even though the
observer stream was arriving normally — the stream is scoped to the owner, not
to the managing install.
When no managed agent matches the working pubkeys, fall back to display entries
derived from the relay profile lookup (
displayName→name→"Agent").Managed entries are still preferred, so the single-install case is unchanged.
Related issue
None found — searched open issues and PRs for "activity bar" / "second device"
/ "non-managing".
Testing
pnpm -C desktop test— 4041 passingpnpm -C desktop typecheck— cleanbiome checkon the touched file — cleanfirst. Before: bar dark on the second machine for the whole turn. After: the
bar renders on both, with the agent's profile display name on the
non-managing one.