feat(acp): add owner broadcast routing - #4644
Conversation
Co-authored-by: Kolton Jacobs <krjhawks@gmail.com> Signed-off-by: Kolton Jacobs <krjhawks@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92df2c6cfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let event = match events.first() { | ||
| Some(e) => e, | ||
| None => return false, | ||
| None => return Some(false), |
There was a problem hiding this comment.
Treat a missing agent profile as unresolved
When an owner explicitly targets a newly created agent whose kind:0 profile has not propagated yet, a successful empty query is not proof that the pubkey belongs to a human. Returning Some(false) here causes owner_broadcast_allows to continue broad delivery, so every older agent can execute a message intended exclusively for the new agent; the negative result is also cached for the process lifetime. Treat an empty or not-yet-attested profile as unresolved (None) or otherwise revalidate it before broadening delivery.
Useful? React with 👍 / 👎.
Summary
owner-broadcastACP subscription modeValidation
bin/just ciOriginating Buzz channel:
7a80f7af-3bec-4e17-a4ee-9f006a6eeac8