fix(buzz-acp): accept siblings under allowlist author gate#1108
Merged
Conversation
The inbound author gate's Allowlist arm accepted only the owner plus the explicit pubkey list, with no sibling check. Switching an agent from owner-only to allowlist (e.g. to add an external collaborator) silently revoked same-owner teammate bots: their @mentions hit the gate's continue and never fired a turn, causing multi-hour agent blackouts. Allowlist now accepts owner + siblings + explicit pubkeys via the same is_owner_or_sibling check used by owner-only. The gate decision is extracted into author_allowed so it can be unit-tested directly. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inbound author gate in
crates/buzz-acp/src/lib.rsdecides which authors' events fire an agent turn. It had an asymmetry between its two owner-dependent modes:OwnerOnlyaccepted the owner and same-owner siblings (other bots launched by the same human, verified via their kind:0 NIP-OA auth tag throughis_owner_or_sibling).Allowlistaccepted only the owner plus the explicit pubkey list — no sibling check.So switching an agent from owner-only to allowlist — e.g. to let an external collaborator
@mentionit — silently revoked recognition of same-owner teammate bots. Their@mentionshit the gate'scontinueand never fired a turn, producing multi-hour agent blackouts where teammate handoffs sat undelivered until a human re-poked the agent.Fix
The
Allowlistarm now accepts owner + siblings + explicit external pubkeys, using the sameis_owner_or_siblingcheck thatOwnerOnlyalready uses. Allowlist was meant to add external people, never to revoke same-owner team bots — this restores that intent.The gate decision is extracted into
author_allowed, which makes the policy logic unit-testable (it previously lived inline inside the longrunloop). The gate call site collapses to a singleawait.Tests
author_gate_testscovers theAllowlistpolicy decision: a same-owner sibling absent from the explicit list is accepted, an explicitly listed external pubkey is accepted, a non-sibling absent from the list is rejected, and the owner is always accepted.