feat: add private text feedback plugin - #242
kalvinnchau wants to merge 8 commits into
Conversation
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Changes requested. Four actionable findings are recorded inline: two P1s (no-outbox render loop and cross-deployment draft retention) and two P2s (native registration and stale Done completion).
Reviewed head c5316922cdeddc07e20e4659e477a5a3b529ca96 against target b86e8d75560277f6b61acdb8c807b17d42c88397; PR diff merge-base d6b01e6b5d159bfa16ace71978ea8230544b8dc4. Validation was static source/contract review, hosted CI inspection, and an isolated React hook-mechanism probe. No PR application code or suites were executed locally; live submission and native UI behavior remain unvalidated.
Merge criteria: fix the four inline defects with boundary/lifecycle coverage. Separately, resolve the current merge conflict and red browser journeys. Hosted run 36063108794 tested merge c57408e: JavaScript, Rust/tool integration, and browser measurements passed; two existing viewport journeys failed in both engines after bounded wheel traversal. The prepended Feedback row changes traversal geometry, but these failures do not establish product clipping or unreachable controls. Repair traversal without weakening visibility assertions and validate both affected files in Chromium/WebKit.
c531692 to
2b3262a
Compare
2386ff5 to
7825a61
Compare
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Remove unused closed-state render fencing and cover real outbox admission near the limit. Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
b1b05fb to
af82c6c
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Source review clear; validation remains incomplete. The four findings from review5310767267 are repaired at af82c6c9949a7a9c6effc1a5b64229789312db92: stable no-outbox rendering, session-scoped drafts, native catalog registration, and stale dismissal completion. I found no additional actionable code blockers in the text-only feedback slice against base df7b7e7f45739f3e06e12d81623385701acdc51d. This is not an approval.
CI run36097958821 tested the matching integration merge. At the 05:32Z snapshot, 658 browser journeys and Rust checks passed; JavaScript was 3719/3720 with the recurring AgentModelPicker failure, and its rerun was still pending. A green required gate was not established. Changed settings/integration tests retain their previous assertions.
Remaining acceptance gaps: no feedback-dialog browser journey (including keyboard focus handoff/return), desktop UI or controlled live-relay submission; Windows validation was skipped. Source/model tests do not prove deployed private-inbox routing or operator review. Resolve the required CI gate and complete the deferred feature acceptance before claiming merge readiness. No PR code was executed during this source-only review.
Scope
Evidence
Keep draft until live validation and CI complete. No browser cases added or removed.