Conversation
this removes dependency on roaring bitmaps
|
OK, so this is the start of a multi-part proposal. The other major parts can be found here: Zapx changes (would need to be cherry-picked to all other branches as well): Bleve changes (confined to scorch): Why?
QuestionsSome of the StatusThere are some rough spots in this worth discussing further, but I wanted to float this and get an initial reaction. |
abhinavdangeti
left a comment
There was a problem hiding this comment.
Looks great to me, especially the go.mod.
|
@abhinavdangeti I generally agree. To me, the API package and bleve side are almost obvious improvements. The possible downside is some perf hit from type assertions in zapx code, and in one case a new allocation (slice of different type). Also, I would be interested in feedback on how I rolled the top-level |
|
It seems if we choose to use a new roaring API downstream, we cannot do away without making a change to this interface. |
this removes dependency on roaring bitmaps