New method named collect_all_version_components to work around HUB_25945#134
Open
New method named collect_all_version_components to work around HUB_25945#134
Conversation
…ll take an "offset" value. New method named collect_all_version_components to work around HUB_25945 where totalCount which is returned by the api is correct but the actual list of items returned is less that totalCount.
gsnyder2007
reviewed
Feb 6, 2021
Contributor
gsnyder2007
left a comment
gsnyder2007
left a comment
There was a problem hiding this comment.
We are working on an improved way to page results that will apply more broadly to all the methods that presently retrieve things like projects, versions, components so collect_all_version_components will become redundant when that happens. Could you please take collect_all_version_components out, and place that in your calling code (that uses get_version_components)? I'll accept the improvement to get_version_components which will allow your code to work as shown (but in your calling program).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameters object to the get_version_components method so it will take an "offset" value. New method named collect_all_version_components to work around HUB_25945 where totalCount which is returned by the api is correct but the actual list of items returned is less that totalCount.