fix package name parsing for direct URL references in pip inspector #1641
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add '@' symbol to regex split pattern to properly extract package names from PEP 440 direct URL references
shantyk
requested review from
bd-samratmuk,
devmehtabd,
dterrybd,
shantyk and
zahidblackduck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '@' symbol to regex split pattern to properly extract package names from PEP 440 direct URL references
Description
The script fails to parse package names when they use direct URL references (PEP 440 format) in requirements.txt files. Add @ to the regex pattern to properly extract package names from direct URL references