fix(mac-certs): Support OpenSSL/LIbreSSL and immediate returns on falure. - #8246
fix(mac-certs): Support OpenSSL/LIbreSSL and immediate returns on falure.#8246enmande wants to merge 1 commit into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR makes three scoped changes to the local-development script Code Review DetailsNo findings. Developer-tooling change only — no production code, dependency, schema, or security-boundary impact. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8246 +/- ##
==========================================
- Coverage 63.87% 63.29% -0.58%
==========================================
Files 2352 2401 +49
Lines 102209 104043 +1834
Branches 9227 9426 +199
==========================================
+ Hits 65287 65857 +570
- Misses 34698 35930 +1232
- Partials 2224 2256 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
PM-42233
📔 Objective
Improves the usability of
create_certificates_mac.shfor local server development as follows:-k ~/Library/Keychains/Login.keychainand uses the default keychain (login, namedlogin.keychain-db, which was not found by the current script).LibreSSL(shipped in/usr/bin) orOpenSSL, which users often bring as a replacement.Verified locally by creating cert with both
LibreSSLandOpenSSL, and seeing cert material flow through to the application.