Skip to content

[BRE-2166] Add metadata to container images - #8241

Open
vgrassia wants to merge 10 commits into
mainfrom
bre-2166_add-metadata-to-container-images
Open

[BRE-2166] Add metadata to container images#8241
vgrassia wants to merge 10 commits into
mainfrom
bre-2166_add-metadata-to-container-images

Conversation

@vgrassia

@vgrassia vgrassia commented Aug 21, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

BRE-2166

📔 Objective

This PR adds metadata to our container images making it easier to debug issues.

@vgrassia
vgrassia requested a review from a team as a code owner August 21, 2026 00:27
@vgrassia vgrassia added the ai-review Request a Claude code review label Aug 21, 2026
@vgrassia
vgrassia requested a review from dani-garcia August 21, 2026 00:27
@vgrassia vgrassia added the t:ci Change Type - Updates to automated workflows label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds OCI image metadata to the Docker build matrix in .github/workflows/build.yml, introducing a per-project description matrix key, a custom-meta step that emits label/annotation pairs to GITHUB_OUTPUT, and a docker/metadata-action step whose outputs feed labels/annotations into the existing docker/build-push-action step. All 16 matrix entries received a description, so the 'Bitwarden service' fallback is defensive only. Values are passed via env: rather than inline ${{ }} interpolation inside the shell body, which avoids script injection, and the new action is SHA-pinned with a version comment consistent with the rest of the workflow.

Code Review Details

No findings met the threshold for posting.

Notes considered and dismissed during review:

  • org.opencontainers.image.revision correctly uses github.event.pull_request.head.sha for PR builds, matching the ref used by the actions/checkout step, rather than the merge commit SHA.
  • com.bitwarden.project set via the workflow overlaps with util/Setup/Dockerfile's existing com.bitwarden.project="setup" label, but the values agree (matrix name is lowercased), so no conflict.
  • Descriptions contain no commas, so list parsing of the multi-line labels/annotations inputs is unambiguous.
  • DOCKER_METADATA_ANNOTATIONS_LEVELS: index,manifest is the appropriate level set for the multi-platform (linux/amd64,linux/arm/v7,linux/arm64) pushes performed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants