You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds OCI image metadata to the Docker build matrix in .github/workflows/build.yml, introducing a per-project description matrix key, a custom-meta step that emits label/annotation pairs to GITHUB_OUTPUT, and a docker/metadata-action step whose outputs feed labels/annotations into the existing docker/build-push-action step. All 16 matrix entries received a description, so the 'Bitwarden service' fallback is defensive only. Values are passed via env: rather than inline ${{ }} interpolation inside the shell body, which avoids script injection, and the new action is SHA-pinned with a version comment consistent with the rest of the workflow.
Code Review Details
No findings met the threshold for posting.
Notes considered and dismissed during review:
org.opencontainers.image.revision correctly uses github.event.pull_request.head.sha for PR builds, matching the ref used by the actions/checkout step, rather than the merge commit SHA.
com.bitwarden.project set via the workflow overlaps with util/Setup/Dockerfile's existing com.bitwarden.project="setup" label, but the values agree (matrix name is lowercased), so no conflict.
Descriptions contain no commas, so list parsing of the multi-line labels/annotations inputs is unambiguous.
DOCKER_METADATA_ANNOTATIONS_LEVELS: index,manifest is the appropriate level set for the multi-platform (linux/amd64,linux/arm/v7,linux/arm64) pushes performed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai-reviewRequest a Claude code reviewt:ciChange Type - Updates to automated workflows
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BRE-2166
📔 Objective
This PR adds metadata to our container images making it easier to debug issues.