Skip to content

[SHOT-252] Move MSSQL base to mcr.microsoft.com/mssql/rhel/server - #8239

Draft
mimartin12 wants to merge 1 commit into
mainfrom
SHOT-252-mssql-ubi9-fips
Draft

[SHOT-252] Move MSSQL base to mcr.microsoft.com/mssql/rhel/server#8239
mimartin12 wants to merge 1 commit into
mainfrom
SHOT-252-mssql-ubi9-fips

Conversation

@mimartin12

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

@mimartin12 mimartin12 added the ai-review Request a Claude code review label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the MSSQL image base swap from mcr.microsoft.com/mssql/server:2025-CU5-ubuntu-22.04 to mcr.microsoft.com/mssql/rhel/server:2025-CU5-rhel-9.1, the gosusetpriv privilege-drop replacement in util/MsSql/entrypoint.sh, and the linux/amd64 platform pin in the build matrix. The setpriv --reuid/--regid --init-groups calls are a faithful gosu equivalent (real, effective, and saved UIDs are all set, and supplementary groups are re-initialized rather than inherited from root), and the added export HOME=/home/$USERNAME correctly compensates for gosu having set $HOME on behalf of the target user. The platform pin is consumed correctly by the Set platforms step, and the Build Docker images (MsSql, ./util, linux/amd64) job passes, confirming the new base resolves and mssql-conf still lives at the expected path.

Code Review Details

No new findings this pass. The previously opened question below is still unresolved and remains the main open item, since CI validates only that the image builds — the entrypoint, healthcheck, and backup loop are never exercised on the new base.

  • ❓ : Was tzdata confirmed present in the RHEL base? backup-db.sh exports TZ and uses date -d; a missing zoneinfo database silently falls back to UTC rather than failing (existing unresolved thread)
    • util/MsSql/Dockerfile:1

PR Metadata Assessment

  • QUESTION: The description is the unmodified template — no objective or test plan.
    • Worth recording how the image was validated (non-root startup, healthcheck via /opt/mssql-tools18/bin/sqlcmd, backup loop) since CI covers none of it.

Comment thread util/MsSql/Dockerfile
@mimartin12 mimartin12 added the t:deps Change Type - Dependencies label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.29%. Comparing base (b045928) to head (1b9e495).
⚠️ Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b045928) and HEAD (1b9e495). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b045928) HEAD (1b9e495)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8239      +/-   ##
==========================================
- Coverage   68.59%   63.29%   -5.30%     
==========================================
  Files        2383     2401      +18     
  Lines      103921   104043     +122     
  Branches     9403     9426      +23     
==========================================
- Hits        71286    65856    -5430     
- Misses      30294    35931    +5637     
+ Partials     2341     2256      -85     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:deps Change Type - Dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant