Skip to content

[PM-38101] Add Staged Provision API Fields#7927

Open
sven-bitwarden wants to merge 9 commits into
mainfrom
ac/pm-38101/wire-staged-provisioning-command
Open

[PM-38101] Add Staged Provision API Fields#7927
sven-bitwarden wants to merge 9 commits into
mainfrom
ac/pm-38101/wire-staged-provisioning-command

Conversation

@sven-bitwarden

@sven-bitwarden sven-bitwarden commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-38101

📔 Objective

Closing in on the saga for Staged users, this PR opens up BWDC and SCIM to provide a new option: InviteUsersAfterProvisioning. When true, the system operates as it does today - provisioned users are invited. When false, users are no longer invited post-provisioning, they are instead added to the new Staged status, wherein they don't occupy seat counts, or really do much of anything in our system except become placeholders for be invited.

@sven-bitwarden sven-bitwarden requested a review from a team as a code owner July 6, 2026 14:14
@sven-bitwarden sven-bitwarden requested a review from JaredScar July 6, 2026 14:14
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of the InviteUsersAfterProvisioning option to the SCIM PostUserCommand and the public API import command (ImportOrganizationUsersAndGroupsCommand), which routes newly provisioned members into the Staged status behind the PM34423StagedStatus feature flag. Verified the feature-flag gating, the ?? true / default-true backward-compatibility behavior, conflict handling, DI registration of ICreateStagedOrganizationUsersCommand, and that the new required interface parameter has no un-updated callers. The change consistently mirrors the existing invite flows and is well covered by unit and integration tests across the flag-on, flag-off, no-config, conflict, and inactive-user cases.

Code Review Details

No findings that met the confidence threshold for posting.

Notes considered and dismissed during review:

  • The new required parameter on IImportOrganizationUserAndGroupsCommand.ImportAsync and OrganizationImportRequestModel.InviteUsersAfterProvisioning both default to true, so existing internal callers and public API consumers are unaffected.
  • SCIM and import staging paths dedupe/lowercase emails via the shared CreateStagedOrganizationUsersCommand, matching the existing invite behavior.
  • The packages.lock.json changes are internal project version bumps (2026.6.0 → 2026.6.2) and lock-file churn, not external dependency changes.

@sven-bitwarden sven-bitwarden added ai-review-vnext Request a Claude code review using the vNext workflow t:feature Change Type - Feature Development labels Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.38%. Comparing base (8ce9409) to head (8cbd42e).

Files with missing lines Patch % Lines
...itwarden_license/src/Scim/Users/PostUserCommand.cs 70.96% 4 Missing and 5 partials ⚠️
.../Import/ImportOrganizationUsersAndGroupsCommand.cs 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           ac/pm-37954/add-staged-provision-command    #7927      +/-   ##
============================================================================
- Coverage                                     65.88%   61.38%   -4.50%     
============================================================================
  Files                                          2238     2238              
  Lines                                         98590    98651      +61     
  Branches                                       8912     8922      +10     
============================================================================
- Hits                                          64956    60558    -4398     
- Misses                                        31401    35951    +4550     
+ Partials                                       2233     2142      -91     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ac/pm-37954/add-staged-provision-command to main July 6, 2026 18:02
@sven-bitwarden sven-bitwarden requested a review from a team as a code owner July 6, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant